Fixing NullReference Exception and not updating nodes on demo site diagram #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, thank you for the PR ! It looks like your PR contains some of my old changes, maybe you need to rebase develop into your branch to only have your changes? I will also leave some comments in specific lines as well Thank you again |
zHaytam
requested changes
Oct 22, 2023
zHaytam
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing a null pointer exception on the demo site diagram, that happened when a link was drawn and released on anything else then a portmodel. Fixes #361.
Fixing the value of the nodes not updating, when the target of a link has changed, because the condition
oldTarget == nullbeing never valid.